Fix creating index-patterns with ccs causes search threadPool to be exhausted #10816
Conversation
kkewwei
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
Maosaic,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
curq,
d-buckner,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ps48,
raintygao,
ruanyl,
sejli,
virajsanghvi,
wanglam,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
kkewwei
requested review from
TackAdam,
paulstn,
ruchidh and
sumukhswamy
as code owners
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 10816.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
|
It seems that I should delete the method |
kkewwei
changed the title
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 10816.yml under folder changelogs/fragments to complete this PR. File still missing. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10816 +/- ##
==========================================
- Coverage 60.56% 60.53% -0.04%
==========================================
Files 4516 4516
Lines 121508 121485 -23
Branches 20300 20295 -5
==========================================
- Hits 73597 73541 -56
- Misses 42749 42788 +39
+ Partials 5162 5156 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There has another place have same logic, we might need remove it as well.
Also, could you share screenshot when you delete this, CCS is still working as expected? |
|
@Hailong-am Thank you for your review. I have deleted the same logic. Your code changes are welcome! Since I’m unfamiliar with Dashboards, I’ve seen your modifications but not yet fully understood their purpose. To proceed with updates in fix_8596, I’ll temporarily move your changes to fix_8596_backup. |
We fix it in opendistro710, it's ok with ccs. |
…xhausted Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]> Signed-off-by: kewei.11 <[email protected]>
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]> Signed-off-by: kewei.11 <[email protected]>
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kewei.11 <[email protected]>
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kewei.11 <[email protected]>
2 participants
Description
The Dashboard currently uses the :/_search endpoint to retrieve indices from CCS clusters, a compatibility measure for Elasticsearch versions prior to 7.10. For later versions, the
RestResolveIndexActioninterface is supported and can fully replace the :/_search endpoint.This means the :/_search endpoint can be removed from the Dashboard code without impacting functionality in this scenario.
Issues Resolved
closes #8596
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration